search

CliMA / LESbrary.jl

📚Generating Oceananigans large eddy simulation (LES) data for calibrating parameterizations
MIT License
27 stars 10 forks source link

Update linear stratification example #104

Closed adelinehillier closed 3 years ago

adelinehillier commented 3 years ago

This PR makes examples/linear_stratification_constant_fluxes.jl identical to examples/three_layer_constant_fluxes.jl except for the initial condition and adds mode = "c" as a keyword argument to all of the NetCDFOutputWriter constructor calls (thanks Ali for this solution!) in both scripts.

glwagner commented 3 years ago

Cool! If many of the lines to these scripts are identical, should we figure out how to share the code rather than copy/pasting?

ali-ramadhan commented 3 years ago

Yeah I agree with @glwagner that it would be nice to add a command line argument to the script to change the stratification between linear, three-layer, and three-layer cubic (maybe there would be too many command line arguments though). But I'm also happy to merge this since it updates and improves existing scripts/examples.

adelinehillier commented 3 years ago

I think the keyword arguments and their defaults are different enough that it probably makes sense to leave the two scripts separate for now, so I'll go ahead and merge, but we can always change in the future!