Change module calls from Buoyancy to BuoyancyModels

CliMA / LESbrary.jl

📚Generating Oceananigans large eddy simulation (LES) data for calibrating parameterizations

MIT License

27 stars 10 forks source link

Closed tomchor closed 3 years ago

tomchor commented 3 years ago

Oceananigans recently renamed the module Buoyancy to BuoyancyModels, which I am just now realizing it's a breaking change.

It seems like you guys haven't been doing this, but since this is a breaking change it might be good to bump the version to 0.1.1.

tomchor commented 3 years ago

Sorry, I forgot to update Project.jl. However, this brings me to a question that I can't decide on my own.

The script src/NearSurfaceTurbulenceModels.jl uses VerstappenAnisotropicMinimumDissipation, which doesn't exist anymore. How should we proceed?

glwagner commented 3 years ago

The script src/NearSurfaceTurbulenceModels.jl uses VerstappenAnisotropicMinimumDissipation, which doesn't exist anymore. How should we proceed?

The object that was once called VerstappenAnisotropicMinimumDissipation is now called AnisotropicMinimumDissipation.

tomchor commented 3 years ago

Sorry, I forgot that was the default AMD SGS model. Just fixed it and now the tests should compile.