search

CliMA / LESbrary.jl

📚Generating Oceananigans large eddy simulation (LES) data for calibrating parameterizations
MIT License
28 stars 10 forks source link

Add Richardson number diagnostic #90

Closed ali-ramadhan closed 3 years ago

ali-ramadhan commented 3 years ago

Thanks @tomchor for Oceanostics.jl!

Resolves #81

Note: This PR depends on #85.

tomchor commented 3 years ago

Per the discussion in https://github.com/tomchor/Oceanostics.jl/issues/1, it's best to wait until the signature of richardson_number_ccf! changes, before merging, no?

ali-ramadhan commented 3 years ago

I'm happy to wait to make the change before merging. Otherwise I think the script will break on master without a future PR.

tomchor commented 3 years ago

@ali-ramadhan Are you going to make that changes in Oceanostics.jl or should I? I might take a little while until I'm able to do it

ali-ramadhan commented 3 years ago

I might be able to but maybe not for a couple of days.

I'll revisit this PR then and if the change hasn't been made I can open a PR on Oceanostics.jl.

tomchor commented 3 years ago

Alright, leave it with me then! I think I can do it faster.