search

CliMA / LandHydrology.jl

The CliMA land hydrology model, including soil, snow, and surface processes
6 stars 0 forks source link

Revert "removed parent calls in src code, added helper fn." #44

Closed kmdeck closed 3 years ago

kmdeck commented 3 years ago

Reverts CliMA/LandHydrology.jl#41

Tests passed locally and in the PR, but then did not pass. Issue is with not initalizing something properly, I think. will revert & fix.

codecov[bot] commented 3 years ago

Codecov Report

Merging #44 (ae7c2b5) into main (60e6341) will decrease coverage by 0.07%. The diff coverage is 80.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   91.78%   91.71%   -0.08%     
==========================================
  Files           8        8              
  Lines         353      350       -3     
==========================================
- Hits          324      321       -3     
  Misses         29       29
Impacted Files Coverage Δ
src/SoilModel/right_hand_side.jl 83.94% <61.53%> (-0.24%) :arrow_down:
src/SoilModel/boundary_conditions.jl 96.38% <100.00%> (-0.05%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60e6341...ae7c2b5. Read the comment docs.