search

CliMA / LandHydrology.jl

The CliMA land hydrology model, including soil, snow, and surface processes
6 stars 0 forks source link

re-implement helper fns #46

Closed kmdeck closed 2 years ago

kmdeck commented 2 years ago

PR 41 passed CI locally and in GH actions, but then upon merge it failed CI. I think it was an issue with initializing an array. I reverted it, but then CI still failed in main. not sure what is going on.

attemping to re-implement and get CI to pass in main in one go.

kmdeck commented 2 years ago

bors try

bors[bot] commented 2 years ago

try

Build failed:

kmdeck commented 2 years ago

bors try

codecov[bot] commented 2 years ago

Codecov Report

Merging #46 (faf7e33) into main (ae7c2b5) will increase coverage by 0.07%. The diff coverage is 86.66%.

:exclamation: Current head faf7e33 differs from pull request most recent head bebee13. Consider uploading reports for the commit bebee13 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   91.71%   91.78%   +0.07%     
==========================================
  Files           8        8              
  Lines         350      353       +3     
==========================================
+ Hits          321      324       +3     
  Misses         29       29
Impacted Files Coverage Δ
src/SoilModel/right_hand_side.jl 84.17% <78.57%> (+0.23%) :arrow_up:
src/Domains/domain.jl 100.00% <100.00%> (ø)
src/SoilModel/boundary_conditions.jl 96.42% <100.00%> (+0.04%) :arrow_up:
src/SoilModel/initial_conditions.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4fcc310...bebee13. Read the comment docs.

bors[bot] commented 2 years ago

try

Build succeeded:

kmdeck commented 2 years ago

bors r+

bors[bot] commented 2 years ago

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}