CliMA / LandHydrology.jl

The CliMA land hydrology model, including soil, snow, and surface processes
6 stars 0 forks source link

move params struct out of LandHydrology.jl #62

Closed kmdeck closed 2 years ago

kmdeck commented 2 years ago

Moving EarthParameterSet definition outside of the LandHydrology.jl module. As per @charleskawczynski, this has to be defined at the driver script level to avoid conflicts between parameter sets internally.

kmdeck commented 2 years ago

bors try

charleskawczynski commented 2 years ago

Thank you!

codecov[bot] commented 2 years ago

Codecov Report

Merging #62 (73367d4) into main (8ccbf83) will decrease coverage by 0.00%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   98.61%   98.61%   -0.01%     
==========================================
  Files          11       10       -1     
  Lines         433      432       -1     
==========================================
- Hits          427      426       -1     
  Misses          6        6              
Impacted Files Coverage Δ
src/SoilModel/models.jl 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ccbf83...73367d4. Read the comment docs.

bors[bot] commented 2 years ago

try

Build succeeded: