Closed ali-ramadhan closed 3 years ago
This PR now also moves my old stuff from ocean_convection.jl
into a local FreeConvection
submodule. This means OceanParameterizations.jl itself doesn't need to depend on heavy packages like DifferentialEquations.jl so it precompiles more quickly now.
@adelinehillier I also added using Statistics
to NeuralNetworks.jl
so it might fix #23.
No worries! Can always work on other branches so no rush on reviewing PRs!
This PR just creates a
OceanParameterizations.PhysicalParameterizations
submodule and makescoarse_grain
work again.It also gets rid of the OceanTurb existing identifier conflict warnings (since both OceanTurb and Oceananigans define
Cell
andFace
):