search

CliMA / Oceananigans.jl

🌊 Julia software for fast, friendly, flexible, ocean-flavored fluid dynamics on CPUs and GPUs
https://clima.github.io/OceananigansDocumentation/stable
MIT License
979 stars 193 forks source link

Don't hardcode coordinate and metric halo fillings for the `ConformalCubedSphereGrid` #3199

Open navidcy opened 1 year ago

navidcy commented 1 year ago

Coordinate and metric halo fillings for the ConformalCubedSphereGrid are hardcoded. E.g.,

https://github.com/CliMA/Oceananigans.jl/blob/2447ea7c15d552fb6a50d3fd347d6534af0018c7/src/MultiRegion/multi_region_cubed_sphere_grid.jl#L296-L324

We need to re-implement this halo-filling utilizing the the connectivity property of the grid. Doing so will

When the latter restriction is alleviated we should remove

https://github.com/CliMA/Oceananigans.jl/blob/2447ea7c15d552fb6a50d3fd347d6534af0018c7/src/MultiRegion/multi_region_cubed_sphere_grid.jl#L293

navidcy commented 6 months ago

This was mostly dealt with #3488 but still the implementation in #3488 requires 1 region per panel.

siddharthabishnu commented 6 months ago

This was mostly dealt with #3488 but still the implementation in #3488 requires 1 region per panel.

Maybe we close this issue (to avoid confusion), and later, create a new one to enable multiple regions per panel and an associated PR (to close it)?

navidcy commented 6 months ago

Could you create the issue you are suggesting and point to the part of the code that it's still outstanding/relevant and then close this one?

glwagner commented 3 months ago

What's the status of this issue?