CliMA / Oceananigans.jl

🌊 Julia software for fast, friendly, flexible, ocean-flavored fluid dynamics on CPUs and GPUs
https://clima.github.io/OceananigansDocumentation/stable
MIT License
970 stars 193 forks source link

CompatHelper: bump compat for JLD2 to 0.5, (keep existing compat) #3769

Closed github-actions[bot] closed 1 day ago

github-actions[bot] commented 3 weeks ago

This pull request changes the compat entry for the JLD2 package from 0.4 to 0.4, 0.5. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

navidcy commented 3 weeks ago

Anybody knows what JLD2 v0.5 changes relevant to us are?

ali-ramadhan commented 3 weeks ago

Not sure of all the changes, but from the changelog a big change is a new type encoder: https://github.com/JuliaIO/JLD2.jl/releases/tag/v0.5.0

Old JLD2 files should still be readable though. And new files are incompatible with JLD2 versions <= v0.4.53.

On that PR it seems like it resolves some JLD2.jl issues with saving functions to disk. Could this mean easy checkpointing of full simulations...? :open_mouth:

glwagner commented 1 week ago

Not sure of all the changes, but from the changelog a big change is a new type encoder: https://github.com/JuliaIO/JLD2.jl/releases/tag/v0.5.0

Old JLD2 files should still be readable though. And new files are incompatible with JLD2 versions <= v0.4.53.

On that PR it seems like it resolves some JLD2.jl issues with saving functions to disk. Could this mean easy checkpointing of full simulations...? 😮

that'd be huge

ali-ramadhan commented 1 day ago

Distributed tests keep failing due to segfaults and MPI communication errors... Is there a trick to get them to work or should I just merge this PR as the non-distributed tests all pass?

glwagner commented 1 day ago

Everything passes now?

ali-ramadhan commented 1 day ago

Yes! Last build I think kept failing even after 4 re-tries. Maybe merging in main did the trick!