search

CliMA / RRTMGP.jl

A Julia implementation of Rapid and accurate Radiative Transfer Model for General Circulation Models.
https://clima.github.io/RRTMGP.jl/latest/
Apache License 2.0
56 stars 4 forks source link

`ClimaParams` is at the same time dependency and weak dependency of RRTMGP #512

Closed Sbozzolo closed 2 months ago

Sbozzolo commented 2 months ago

https://github.com/CliMA/RRTMGP.jl/blob/7d984ef02fa40e939e02b8650d2286f387029492/Project.toml#L10

should probably be removed?

Sbozzolo commented 2 months ago

@nefrathenrici could you take a look at this?

nefrathenrici commented 2 months ago

https://github.com/CliMA/RRTMGP.jl/blob/7d984ef02fa40e939e02b8650d2286f387029492/src/RRTMGP.jl#L27-L29

This was intended to allow backwards compatibility with older Julia versions , but given that the minimum version is now 1.9, ClimaParams should just be a weakdep.