search

CliMA / RRTMGP.jl

A Julia implementation of Rapid and accurate Radiative Transfer Model for General Circulation Models.
https://clima.github.io/RRTMGP.jl/latest/
Apache License 2.0
56 stars 4 forks source link

Update ClimaParams compat #514

Closed nefrathenrici closed 2 months ago

nefrathenrici commented 2 months ago

RRTMGP depends on new parameters added in ClimaParams v0.10.8, this ensures that older versions will not be grabbed.

I have also updated the docs manifest.

szy21 commented 2 months ago

Was ClimaParams just removed here: https://github.com/CliMA/RRTMGP.jl/pull/513?

nefrathenrici commented 2 months ago

Was ClimaParams just removed here: #513?

ClimaParams was removed as a direct dependency, is still a weakdep for the extension.

szy21 commented 2 months ago

Was ClimaParams just removed here: #513?

ClimaParams was removed as a direct dependency, is still a weakdep for the extension.

I see. What parameters in v0.10.8 are used? (https://github.com/CliMA/ClimaParams.jl/pull/198 is used in ClimaAtmos, not RRTMGP). We can still update the compat though.

nefrathenrici commented 2 months ago

Was ClimaParams just removed here: #513?

ClimaParams was removed as a direct dependency, is still a weakdep for the extension.

I see. What parameters in v0.10.8 are used? (CliMA/ClimaParams.jl#198 is used in ClimaAtmos, not RRTMGP). We can still update the compat though.

If the parameters are only used in Atmos, we should keep the compat lower here. I will make sure the update the atmos compat.