search

CliMA / SCAMPy

A single column model of atmospheric boundary layer turbulence and clouds
Apache License 2.0
5 stars 2 forks source link

case-specific if/else in Turbulence_PrognosticTKE #37

Open trontrytel opened 5 years ago

trontrytel commented 5 years ago

@ilopezgp @yairchn do we want to have case-specific if/else statements inside the actual scampy code? I think this should all be handled by the case setup

https://github.com/climate-machine/SCAMPy/blob/4335fd21842629ad00279358025dc0ecf1a95f89/Turbulence_PrognosticTKE.pyx#L1622-L1653

ilopezgp commented 5 years ago

@trontrytel The structure of the code initializes covariances in the self.TS==0 inside the update function of EDMF_PrognosticTKE.

I agree it would be cleaner to initialize everything in the case setup initialization. We would have to move the initialization functions to Cases.pyx.

yairchn commented 5 years ago

I think that the initial profile of covariances , just as the initial profile of the mean, should be in cases.