search

CliMA / SeawaterPolynomials.jl

Polynomials for efficiently computing the density of seawater
https://clima.github.io/SeawaterPolynomials.jl/dev
MIT License
14 stars 3 forks source link

Equation of State for TEOS10: Depth vs Height #19

Closed sandreza closed 2 years ago

sandreza commented 2 years ago

It seems that the Roquet et. al paper uses a different sign convention in the following definition

Screen Shot 2022-05-05 at 11 41 40 PM

as compared to what is in the package:

https://github.com/CliMA/SeawaterPolynomials.jl/blob/5f278c85e849d402de9d45f20fa3f227e0b8e6fc/src/TEOS10.jl#L68

This can lead to subtle sign errors that propagate to other code bases

glwagner commented 2 years ago

I think we should add a minus sign to

https://github.com/CliMA/SeawaterPolynomials.jl/blob/5f278c85e849d402de9d45f20fa3f227e0b8e6fc/src/TEOS10.jl#L68

we also have to update a test.

glwagner commented 2 years ago

Thanks a lot @sandreza for finding this!

sandreza commented 2 years ago

closed via #20