search

CliMA / SeawaterPolynomials.jl

Polynomials for efficiently computing the density of seawater
https://clima.github.io/SeawaterPolynomials.jl/dev
MIT License
13 stars 2 forks source link

Verification and testing of polynomial implementation *and* accuracy? #2

Open glwagner opened 4 years ago

glwagner commented 4 years ago

How should we verify the accuracy and correctness of these polynomials?

We can use the official TEOS-10 implementation, perhaps:

https://github.com/TEOS-10/GibbsSeaWater.jl

This package is not updated very often, but as long as it straightforwardly wraps the official C implementation, I think we are good.

It may not be unreasonable to do 'verification' of the Roquet polynomials (against the TEOS-10 implementation) as well, by obtaining climatological temperature and salinity (or any other product), and comparing the density anomalies, thermal expansion, and haline contraction between the two.

glwagner commented 4 years ago

5 adds a test that uses 'check values' from Roquet et al. 2015.