Closed jbisits closed 1 year ago
Patch coverage: 100.00
% and project coverage change: +18.25
:tada:
Comparison is base (
8873d32
) 62.90% compared to head (6f70669
) 81.15%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
R₀₀₀ does not appear in the thermal sensitivity or haline sensitivity
Sorry, my mistake! Have now corrected thermal_sensitivity
and haline_sensitivity
.
Note that R₀₀₀ is in fact equal to the reference density at the ocean surface. That's why we omit this coefficient. I think we should remove R₀₀₀ from this PR. However, we could add some additional explanation about the potential role of the "double zero" coefficients. With this equation of state, we cannot recover the in situ density at all depths because these coefficients are not tabulated by Roquet.
For reference (apologies about the resolution), here is the part of the paper that details the density_anomaly
for the simplest yet "realisitic" eos in Roquet et al. (2015)
This is why I added the R₀₀₀
to SecondOrderSeawaterPolynomial
because then we have
$$ \rho = \rho_{r} + \rho' $$
where $\rho'$ is equation (17) in the excerpt above which has the R₀₀₀
coefficient.
I am happy to be guided by you on this and remove R₀₀₀
but the inclusion of R₀₀₀
is only for this :SimplestRealisitcRoquetSeawaterPolynomial
as in all other cases R₀₀₀ = 0
.
I am happy to be guided by you on this and remove R₀₀₀ but the inclusion of R₀₀₀ is only for this :SimplestRealisitcRoquetSeawaterPolynomial as in all other cases R₀₀₀ = 0.
R₀₀₀
has no effect on dynamics (or anything) right? What's the point of including it?
R₀₀₀
has no effect on dynamics (or anything) right? What's the point of including it?
Yes that is right. The inclusion of R₀₀₀
was just to be faithful to the Roquet et al. (2015) suggestion for the simplest "realistic" eos equation (17). Effectively R₀₀₀
shifts the reference density by
(-0.011 * (-4.5)^2) / 2 # = -0.11137499999999999
so removing R₀₀₀
is not likely to change things too much, so I will remove it now.
I think that's for the best, because ideally users should not set or puzzle over this parameter. We can consider it absorbed into the user definition of reference density (which may also be used for thermodynamics calculations, etc).
thanks!
Purpose
Add the
coefficient_set
for the simplest yet "realisitic" equation of state from Roquet et al. (2015) and updateBase.show
for::SecondOrderSeawaterPolynomial
so that coefficients match variables. Closes #27Content
The simplest yet "realistic" equation of state for seawater from Roquet et al. (2015) is equation (17). Following (17) the coefficients in the form $R_{\beta\chi\varphi}$ are given. This
coefficient_set
and tests are added to thecoefficient_set
s already in this package from Roquet et al. (2015), providing another equation of state that can be used.This PR also updates
Base.show
so that the coefficients match the variables.Apologies if this should have been two PR's, I only discovered #27 at the end of what I had initially set out to do which was add the simplest "realistic" eos from Roquet et al. (2015).
Review checklist
I have:
In the Content, I have included
References
Roquet et al., "Defining a Simplified Yet “Realistic” Equation of State for Seawater", Journal of Physical Oceanography (2015)