search

CliMA / SurfaceFluxes.jl

A package for computing surface fluxes between the atmosphere, ocean and land models.
https://clima.github.io/SurfaceFluxes.jl/dev/
Apache License 2.0
17 stars 4 forks source link

Hide code branch that leads to GPU incompatibilities in Julia 1.10 #143

Closed Sbozzolo closed 10 months ago

Sbozzolo commented 10 months ago

As of CUDA 5.1.1, there are some issues with ClimaAtmos and Julia 1.10. It seems that the issue is with this particular function and the error is due to added calles to gc_frame functions that cannot be compiled on a GPU.

For unknown reasons, the code compiles when we remove the keyword arguments. While the issue is being investigated, we can work around it by excluding the offending branch

Includes house cleaning.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (00c859a) 89.46% compared to head (2752e61) 89.49%. Report is 1 commits behind head on main.

:exclamation: Current head 2752e61 differs from pull request most recent head 7ebe141. Consider uploading reports for the commit 7ebe141 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #143 +/- ## ========================================== + Coverage 89.46% 89.49% +0.02% ========================================== Files 3 3 Lines 788 790 +2 ========================================== + Hits 705 707 +2 Misses 83 83 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

charleskawczynski commented 10 months ago

Do you have a reproducer?

Sbozzolo commented 10 months ago

Do you have a reproducer?

Current ClimaAtmos fails. Just run ClimaAtmos.get_simulation(ClimaAtmos.AtmosConfig()) on a GPU with julia 1.10.

@simonbyrne and I tried debugging this and concluded that it is a difficult problem and it is best to move ahead with upgrading ClimaAtmos to 1.10 while the root issue is being investigated.

With this workaround, everything runs, as in: https://buildkite.com/clima/climaatmos-ci/builds/15625