search

CliMA / Thermodynamics.jl

A package containing a library of moist thermodynamic relations.
https://clima.github.io/Thermodynamics.jl/dev/
Apache License 2.0
61 stars 2 forks source link

(Try 2) Improve the explanation surrounding "virtual temperature" and a hypothetical "density temperature" #174

Closed glwagner closed 8 months ago

glwagner commented 9 months ago

Supercedes #171, trying again now that I have contributor privileges.

From #171:

I thought the description could be improved by being a little more explicit. If I've made a mistake, let me know and I can fix it. I also embellished the "side point" by putting it in a box to emphasize that this is additional information that isn't core to understanding the main thread.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8de5393) 93.02% compared to head (2b97107) 93.02%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #174 +/- ## ======================================= Coverage 93.02% 93.02% ======================================= Files 9 9 Lines 1133 1133 ======================================= Hits 1054 1054 Misses 79 79 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

glwagner commented 9 months ago

@charleskawczynski looks like buildkite won't run for this either

charleskawczynski commented 9 months ago

@glwagner, we have a label to launch buildkite in thermodynamics, looks like it's started now 🎉

glwagner commented 9 months ago

@glwagner, we have a label to launch buildkite in thermodynamics, looks like it's started now 🎉

got it

charleskawczynski commented 8 months ago

I'll go ahead and rebase this PR @glwagner

charleskawczynski commented 8 months ago

I think we were experimenting with the buildkite settings, and CI was not working because of that. Hopefully things should be smooth moving forward.