CliMA / Thermodynamics.jl

A package containing a library of moist thermodynamic relations.
https://clima.github.io/Thermodynamics.jl/dev/
Apache License 2.0
61 stars 2 forks source link

Update deps and julia version #180

Closed charleskawczynski closed 8 months ago

charleskawczynski commented 8 months ago

This PR:

charleskawczynski commented 8 months ago

Thanks for removing UnPack! Is there a reason we are updating the GH actions now? I can make this change in other repositories as well. We should also remove the ci 1.6 merge requirement.

I just haven't gotten around to it. I want to add some kernel benchmark tests, but that required upgrading TD to julia 1.10 for CUDA/KA compatibility. So that was kind of blocking me.

And yes, feel free to upgrade in other repos as well.

Agreed, I'll remove the 1.6 check

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3d600e0) 93.06% compared to head (5f1bd59) 93.07%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #180 +/- ## ========================================== + Coverage 93.06% 93.07% +0.01% ========================================== Files 10 10 Lines 1139 1141 +2 ========================================== + Hits 1060 1062 +2 Misses 79 79 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

charleskawczynski commented 8 months ago

Something seems wrong with macos on julia 1.10, seems unrelated to this PR.