search

CliMA / Thermodynamics.jl

A package containing a library of moist thermodynamic relations.
https://clima.github.io/Thermodynamics.jl/dev/
Apache License 2.0
61 stars 2 forks source link

Convert data-based test to sampling-based test #181

Closed charleskawczynski closed 8 months ago

charleskawczynski commented 8 months ago

This PR removes the use of the collected dataset, and replaces it with a sampling-based test based on the range of the dataset. I can confirm that the new tests works for maxiter = 4 and fails for maxiter = 3, which seems sufficient in terms of replacing the use of the dataset. This is nice because now we can remove ArtifactWrappers and NCDatasets from the test environment.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (de98c9f) 93.06% compared to head (a10916e) 93.06%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #181 +/- ## ======================================= Coverage 93.06% 93.06% ======================================= Files 10 10 Lines 1139 1139 ======================================= Hits 1060 1060 Misses 79 79 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.