search

CliMA / Thermodynamics.jl

A package containing a library of moist thermodynamic relations.
https://clima.github.io/Thermodynamics.jl/dev/
Apache License 2.0
61 stars 2 forks source link

Why is density an input to `virtual_temperature`? #190

Closed glwagner closed 8 months ago

glwagner commented 8 months ago

It's an input:

https://github.com/CliMA/Thermodynamics.jl/blob/20de40f66170bca8deeff394c1880dd0559a27b7/src/relations.jl#L2579

but is not used:

https://github.com/CliMA/Thermodynamics.jl/blob/20de40f66170bca8deeff394c1880dd0559a27b7/src/relations.jl#L2582-L2583

charleskawczynski commented 8 months ago

This is a mistake, we can remove it.