search

CliMA / Thermodynamics.jl

A package containing a library of moist thermodynamic relations.
https://clima.github.io/Thermodynamics.jl/dev/
Apache License 2.0
61 stars 2 forks source link

Remove type restriction on e_pot #203

Closed dennisYatunin closed 7 months ago

dennisYatunin commented 7 months ago

Another followup to #200 and #201. When using SurfaceFluxes with Dual numbers, we need to compute the virtual_dry_static_energy of a thermodynamic state, where the state is specified using Dual numbers but its potential energy is specified as a regular Float32/Float64. This PR removes the restriction that the type of e_pot must match the eltype of the thermodynamic state for virtual_dry_static_energy and moist_static_energy (which follows the same pattern).

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.93%. Comparing base (6bf8059) to head (20a633f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #203 +/- ## ======================================= Coverage 90.93% 90.93% ======================================= Files 10 10 Lines 1180 1180 ======================================= Hits 1073 1073 Misses 107 107 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.