CliMA / TurbulenceConvection.jl

A turbulence-convection single column model cloud parameterization.
https://clima.github.io/TurbulenceConvection.jl/dev/
Apache License 2.0
32 stars 4 forks source link

Use exponential detrainment limiter and apply to all entr function types #1363

Closed costachris closed 1 year ago

costachris commented 1 year ago

Use exponential detrainment limiter instead of the currently-used logistic function and apply to all entr function types.

Original

$$ \left(2 - \frac{1}{{1 + \exp(-\gamma{lim} \times (a{max} - a_{up}))}}\right)^{\beta_{lim}} - 1$$

Exponential

$$ \gamma{lim} \exp(-\beta_{lim} \times (a{max} - a_{up}))$$

A comparison of the two formulations is provided below (one on a log scale)

combined_max_area_limiter_plot combined_max_area_limiter_logistic_plot_logscale

szy21 commented 1 year ago

Oh, a minor thing. If you make this change the description in CLIMAParameters is not accurate anymore: https://github.com/CliMA/CLIMAParameters.jl/blob/945eb72ea84cf5ad8231bcdd7715e8a57dd11e45/src/parameters.toml#L2250-L2260. Not sure if we should change it too?

costachris commented 1 year ago

bors r+

bors[bot] commented 1 year ago

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.