CliMA / TurbulenceConvection.jl

A turbulence-convection single column model cloud parameterization.
https://clima.github.io/TurbulenceConvection.jl/dev/
Apache License 2.0
29 stars 4 forks source link

New closure implementation overview #665

Open haakon-e opened 2 years ago

haakon-e commented 2 years ago

Overview of approaches to try for entrainment/detrainment closures.

Closures to be implemented and tested/calibrated. (responsible team in parenthesis)

note: closures are implemented on branches off of the main branch

charleskawczynski commented 2 years ago

Just to note, we should probably develop off of the main branch (via clones of TC.jl, not forks) since it'll be easier to keep synchronized (and therefore easier to merge new developments). I'd prefer that model/ML developers commit changes to ~the main branch~ branches off the main branch-- we can add a ModelDev folder where we merge more changes freely.

This way, as we make refactoring changes, we can more quickly and generally apply them to development work too.

I can help assist / facilitate how this ModelDev folder interacts with the model, so that model/ML developers can add tests that ensure at least some portion of the development code stays synchronized.

For now, I'll try generalizing the following functions so that they're hack-able outside of src/:

@haakon-e, please let me know if there are any other functions that may need to be overloaded outside of src/.

costachris commented 2 years ago

@charleskawczynski compute_turbulent_entrainment(param_set, εδ_model_vars) will likely not be changed or overloaded by us, since we're only working on the dynamical entrainment.