search

CliMT / climt

The official home of climt, a Python based climate modelling toolkit.
https://climt.readthedocs.io
Other
160 stars 46 forks source link

McICA for SW radiation #67

Closed lkluft closed 5 years ago

lkluft commented 6 years ago

Hey,

this is more a question than a real issue 😉

The LW component of RRTMG uses McICA to represent cloud variability, while the SW component is hard-coded to the non-McICA implementation.

Is there a special reason for this design decision?

Cheers, Lukas

lkluft commented 6 years ago

Update: I just now realised that the implementation is identical to the official RRTMG source.

So it seems that one has to manually call the mcica_subcol_sw routine before one can use the SW-McICA.

Are there any plans to implement this as an (optional) feature for CliMT or is this out of scope?

mcgibbon commented 6 years ago

@JoyMonteiro can answer better whether he plans to implement this feature, but I would imagine if someone wanted to submit a PR implementing it there would be no complaints. I'd be willing to give guidance and assistance if you or someone else wants to do it.

JoyMonteiro commented 6 years ago

This is on my to-do list, but keeps getting pushed down the line. I will keep this issue open to remind me. We definitely want a MCICA version since RRTMG shortwave cannot handle cloud fractions otherwise (only 0 or 1 are valid inputs).

Of course, any help is always welcome :)

lkluft commented 6 years ago

Thanks for the quick response!

We (cc @SallyDa) will try to implement the SW-MCICA version. But we are new to Cython (and its infrastructure), so it will probably include fiddling around a bit 😉

We will come back to you if we are completely stuck at some point.

JoyMonteiro commented 6 years ago

I would recommend waiting for a week before starting off on this. As you may have noticed, there is a major refactor going on, and we plan to release a version by next week. It is likely that this version will eventually become climt 1.0, and few API changes are expected.

The new API at the climt level will not change at all for single column components like RRTMG, FYI.

mcgibbon commented 6 years ago

I would expect it's fine for @lkluft and @SallyDa to get started once we release the paper version, which should be today or Monday at the latest. Just be aware there will be changes to merge along the way.

mcgibbon commented 6 years ago

Mostly the RRTM component will be insulated from the near future changes, I believe.

JoyMonteiro commented 6 years ago

OK, we are live!

JoyMonteiro commented 5 years ago

@SallyDa @lkluft, I wanted to enquire before I close this issue: are you planning to do something similar for RRTMG Longwave as well? if not, I think I will take this up in a couple of weeks.

SallyDa commented 5 years ago

Yes, it's almost done :)

JoyMonteiro commented 5 years ago

Excellent! will look forward to that then :) Closed by https://github.com/CliMT/climt/pull/83/.