ClickHouse / ClickHouse

ClickHouse® is a real-time analytics DBMS
https://clickhouse.com
Apache License 2.0
36.75k stars 6.8k forks source link

02492_clickhouse_local_context_uaf checks nothing but it is broken #69561

Open CheSema opened 5 days ago

CheSema commented 5 days ago

https://github.com/ClickHouse/ClickHouse/pull/43409

In the CI it checks nothing because there is no tty and stdin is closed so the test runs in non-interactive mode and there are neither the error is triggered nor the message is printed in stderr/stderr.

But if you try to run in on your dev machine in some tty, then you see that it works as supposed to but it is broken by this change: https://github.com/ClickHouse/ClickHouse/pull/51518 here https://github.com/ClickHouse/ClickHouse/blob/4d87cf23447868643b7e0e9986d3a272549bdfcd/src/Client/ClientBase.cpp#L2301

CheSema commented 5 days ago

FYI @azat