search

ClickHouse / clickhouse-cpp

C++ client library for ClickHouse
Apache License 2.0
305 stars 159 forks source link

Add rvalue vector ctors for ColumnDate, ColumnDate32 and ColumnIPv4 #332

Closed bduminiuc closed 1 year ago

bduminiuc commented 1 year ago

These constructors can be valuable for enhancing performance in scenarios where a user knows the row count and can preallocate memory.

I also considered adding a similar constructor for ColumnDateTime, but its public interface exclusively utilizes time_t, while uint32_t is an implementation detail. I'm unsure if extending the interface with implementation details would be a good idea.

bduminiuc commented 1 year ago

Hi, @Enmk,

The constructor for ColumnDateTime and the unit tests mentioned earlier were added.