search

ClickHouse / clickhouse-cpp

C++ client library for ClickHouse
Apache License 2.0
306 stars 159 forks source link

Added `GetSize()` const method for FixedStringType #355

Closed german3w1 closed 10 months ago

german3w1 commented 10 months ago

By using ColumnLowCardinalityT, you lose the ability to conveniently know the fixed size parameter of ColumnFixedString. Adding this method fixes this issue.

CLAassistant commented 10 months ago

CLA assistant check
All committers have signed the CLA.

Enmk commented 10 months ago

Hi @german3w1 ! Thank your contribution, could you please add some unit-test for this method? Nothing fancy, since the method itself is pretty straightforward.

Otherwise it looks Ok

german3w1 commented 10 months ago

I think three unit-tests are enough to prove the method works as expected :)

german3w1 commented 10 months ago

The building script for Mac with ssl support enabled seems broken to me. Other checks were successful so I think it can be merged now

german3w1 commented 10 months ago

image Don't understand what's wrong with the connection in this test but the RoundTrip tests were failed due to this

german3w1 commented 10 months ago

@Enmk kind ping