Make custom debug log function on-par with the built-in one

ClickHouse / clickhouse-go

Golang driver for ClickHouse

Apache License 2.0

2.88k stars 553 forks source link

Make custom debug log function on-par with the built-in one #1317

Closed vespian closed 4 months ago

vespian commented 4 months ago

Summary

The built-in debug-log function was printing more information than the custom one could. This PR makes them on-par by providing the wrapper.

I think this can be considered backwards-compatible, but I would be happy to hear your opinion on this. This is just a debug message after all and we just prefix it with extra data.

CLAassistant commented 4 months ago

All committers have signed the CLA.

vespian commented 4 months ago

@jkaflik PTAL :pray:

vespian commented 4 months ago

@jkaflik Fixed - both CLA and tests failures. PTAL.

vespian commented 4 months ago

@jkaflik I have run tests locally and they passed. I am unfamiliar with your testing setup and whether the failures here are legit.

Is there anything I could help here with?

jkaflik commented 4 months ago

No worries. We have CI runners instability - I will take care of it.