Closed chernser closed 2 weeks ago
Thanks @mzitnik! I've replaced code with shared constant from ClientSettings
.
Thanks @mzitnik! I've replaced code with shared constant from
ClientSettings
.
Actually was referring if we can have a common base class since there is shared code
Failed conditions
50.0% Coverage on New Code (required ≥ 80%)
@mzitnik I think, we should not do it to keep developer away from idea of extracting common part. I do not plan to add all server settings in such way and it should not be a problem for maintenance. What I'm afraid of that joining two separate mechanisms will lead to more rigid code and it will not save time as intendent.
Summary
There is an option to set a comment that will be seen in
system.query_log
record associated with a query. It is useful for troubleshooting. In case of HTTP interface client should send the comment thru query parameterlog_comment
.Closes: https://github.com/ClickHouse/clickhouse-java/issues/1836
Checklist
Delete items not relevant to your PR: