client-V2 com.clickhouse.client.api.metrics.Metric.getLong()

[lelewolf]

Describe the bug

After executing an SQL query, attempting to retrieve ServerMetrics.ELAPSED_TIME or ServerMetrics.RESULT_ROWS from OperationMetrics results in a NullPointerException. This error indicates that metrics.getMetric() is returning null, likely because the OperationMetrics instance did not record the relevant metrics correctly.

Steps to reproduce

1. Configure the ClickHouse client and run the following code.
2. Call the executeSQL method, passing in an SQL query and queryId.
3. Observe the logs to see if the error message appears: Cannot invoke "com.clickhouse.client.api.metrics.Metric.getLong()" because the return value of "com.clickhouse.client.api.metrics.OperationMetrics.getMetric(com.clickhouse.client.api.metrics.ServerMetrics)" is null.

Expected behaviour

Code example

public QueryResult executeSQL(String sql, String queryId) throws Exception {
    QuerySettings settings = createQuerySettings(queryId);
    log.info("开始执行查询，queryId:{},sql:{},settings:{}", queryId, sql,
        JSON.toJSONString(settings));
    try {
      QueryResponse response = executeSQLQuery(sql, settings);
      OperationMetrics metrics = response.getMetrics();
      metrics.operationComplete();
      log.info("SQL 查询执行时间: {} 毫秒， 查询查询结果条数: {}", metrics.getMetric(ServerMetrics.ELAPSED_TIME), metrics.getMetric(ServerMetrics.RESULT_ROWS));
      log.info("SQL 查询结果: {}", JSON.toJSONString(metrics));
      return buildQueryResult(jsonResult,metrics);
    } catch (InterruptedException | ExecutionException e) {
      log.error("SQL执行失败: {}", sql, e);
      throw new SQLException("Error executing SQL: " + sql, e);
    }
  }

Error log

Cannot invoke "com.clickhouse.client.api.metrics.Metric.getLong()" because the return value of "com.clickhouse.client.api.metrics.OperationMetrics.getMetric(com.clickhouse.client.api.metrics.ServerMetrics)" is null

Configuration

Environment

• Client version: client-v2 0.7.1
• Language version: java
• OS: mac

ClickHouse server

• ClickHouse Server version:23.3.2.1
• ClickHouse Server non-default settings, if any:
• CREATE TABLE statements for tables involved:
• Sample data for all these tables, use clickhouse-obfuscator if necessary

[chernser]

@lelewolf Thank you for reporting! We will look into it.

[chernser]

Good day, @lelewolf !

I've not reproduced the issue. Here is my PR with test https://github.com/ClickHouse/clickhouse-java/pull/1914 Few things to mention:

• user code should not call "completeOperation()" for metrics that have got from a response object - client has done it already.
• what is implementation of executeSQLQuery in your code? Is it doing something with metrics?

Thanks!