search

ClickHouse / clickhouse-js

Official JS client for ClickHouse DB
https://clickhouse.com
Apache License 2.0
189 stars 22 forks source link

BaseQueryParams.session_id is not used #271

Closed Holi0317 closed 1 month ago

Holi0317 commented 2 months ago

Describe the bug

BaseQueryParams got an undocumented session_id that feels like it should override the session_id passed into createClient. But actually that field is never used and session_id is always using this.sessionId https://github.com/ClickHouse/clickhouse-js/blob/ad8611e736a82d98416c1d99d903240df02d7ace/packages/client-common/src/client.ts#L253

Steps to reproduce

  1. Try to override session_id via BaseQueryParams

Expected behaviour

The session_id should be overridden

slvrtrn commented 1 month ago

Fixed in 1.1.0. Also, session id override will be mentioned in the docs after https://github.com/ClickHouse/clickhouse-docs/pull/2381 is merged.