chore: allow passing a socket connection to https.Agent

ClickHouse / clickhouse-js

Official JS client for ClickHouse DB

https://clickhouse.com

Apache License 2.0

189 stars 22 forks source link

chore: allow passing a socket connection to https.Agent #275

Closed ereio closed 2 months ago

ereio commented 2 months ago

chore: allow passing a socket connection to https.Agent

Summary

A short description of the changes with a link to an open issue.

Checklist

Delete items not relevant to your PR:

[ ] Unit and integration tests covering the common scenarios were added
[ ] A human-readable description of the changes was provided to include in CHANGELOG
[ ] For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

CLAassistant commented 2 months ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

slvrtrn commented 2 months ago

Let's create an issue first and discuss a possible implementation there. Direct tinkering with the underlying sockets can open a whole can of worms.

Socket connection for https.Agent override - helpful when connecting through a proxy

Do we need anything other than the additional_http_headers in this case?