search

ClickHouse / clickhouse-rs

Official pure Rust typed client for ClickHouse DB
https://clickhouse.com
Apache License 2.0
283 stars 84 forks source link

hyper-rustls: add ring Rustls backend & use it by default #140

Closed blind-oracle closed 1 week ago

blind-oracle commented 1 week ago

Recently rustls crate switched to the aws-lc-rs crypto backend by default (probably because it's FIPS certified) which requires a C compiler to build, which adds unnecessary complexity.

This PR makes hyper-rustls use pure Rust ring backend by default with an option to use aws-lc-rs through rustls-tls-aws feature.

CLAassistant commented 1 week ago

CLA assistant check
All committers have signed the CLA.

loyd commented 18 hours ago

@blind-oracle

... requires a C compiler to build, which adds unnecessary complexity. This PR makes hyper-rustls use pure Rust ring backend by default with an option to use aws-lc-rs through rustls-tls-aws feature.

Isn't ring non pure-Rust? https://github.com/briansmith/ring/blob/7c0024abaf4fd59250c9b79cc41a029aa0ef3497/build.rs#L348

serprex commented 10 hours ago

they were somewhat inaccurate, build issues tend to be NASM related on Windows, but it's been improving: https://github.com/rustls/rustls/issues/1913