feat: Add ability to set sql security option

ClickHouse / dbt-clickhouse

The Clickhouse plugin for dbt (data build tool)

Apache License 2.0

253 stars 113 forks source link

feat: Add ability to set sql security option #379

Open dev-mkc19 opened 2 weeks ago

dev-mkc19 commented 2 weeks ago

resolve SQL security and definer logic #359

Summary

Starting from v.24.2 ClickHouse have sql security and definer logic (for view), this changes add ability to use this feature within dbt.

Checklist

Delete items not relevant to your PR:

[ ] Unit and integration tests covering the common scenarios were added
[x] A human-readable description of the changes was provided to include in CHANGELOG
[ ] For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

CLAassistant commented 2 weeks ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Mikhail K seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

dev-mkc19 commented 2 weeks ago

@genzgd Hi. Could you look at my changes quickly please. I have doubt with the following question:

Is it appropriate implementation? (perhaps there are some hidden/unwritten rules which might block merge)
Where to place tests? I couldn't find existing .py file with the test cases for view. Does the structure of py files fixed or I can create for instance tests/integration/adapter/view/test_base_view.py?
Should I implement this feature for materialized views also or it's not necessary now?