ClickHouse / homebrew-clickhouse

ClickHouse Homebrew tap (old repository, unused)
57 stars 7 forks source link

Add ClickHouse v22.8 #59

Closed rschu1ze closed 1 year ago

rschu1ze commented 1 year ago

Currently getting

[...]
-- Performing Test SUPPORTS_CFLAG_no_enum_constexpr_conversion
-- Performing Test SUPPORTS_CFLAG_no_enum_constexpr_conversion - Success
-- No official build: A checksum hash will not be added to the clickhouse executable
-- Default libraries: -nodefaultlibs  -lc -lm -lpthread -ldl
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Check if compiler accepts -pthread
-- Check if compiler accepts -pthread - no
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - not found
CMake Error at /opt/homebrew/Cellar/cmake/3.26.4/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
Could NOT find Threads (missing: Threads_FOUND)
Call Stack (most recent call first):
/opt/homebrew/Cellar/cmake/3.26.4/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
/opt/homebrew/Cellar/cmake/3.26.4/share/cmake/Modules/FindThreads.cmake:226 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
cmake/darwin/default_libs.cmake:23 (find_package)
CMakeLists.txt:440 (include)

-- Configuring incomplete, errors occurred!
rschu1ze commented 1 year ago

Happens also when brewing the existing v22.7 :-(

rschu1ze commented 1 year ago

Steps:

brew tap clickhouse/clickhouse
cd $(brew --repository clickhouse/clickhouse)
export HOMEBREW_NO_INSTALL_FROM_API=1
brew install --verbose --build-from-source clickhouse/clickhouse/clickhouse@22.7
alexey-milovidov commented 1 year ago

Is it possible to ignore everything Homebrew related and build ClickHouse as close as possible to the official instruction?

rschu1ze commented 1 year ago

It fails also with vanilla build instructions 😢

@traceon Don't want to bother you too much, it looks like you moved on to another job. The homebrew repo was recently moved from Altinity to ClickHouse. My attempt to compile the last included version v22.7 failed (see above). But since I am not great with Homebrew, I possibly missed something. Maybe you remember the steps to build the code locally, i.e. without GitHub runners?

rschu1ze commented 1 year ago

@traceon provided a viable workaround (thanks) for the pthread issue.

I now get lots of compiler errors when building v22.8 with clang-16. I guess we should skip the old versions and jump directly to v23.5. Will do that in a new PR. --> #60