ClickHouse / metabase-clickhouse-driver

ClickHouse database driver for the Metabase business intelligence front-end
Apache License 2.0
461 stars 84 forks source link

replace the usage of u/snake-key with u/->snake_case_en #160

Closed dodg3this closed 12 months ago

dodg3this commented 1 year ago

Summary

Clickhouse driver fails at syncing databases with the latest metabase release (version 0.46.3) with the below error:

java.lang.IllegalStateException: Attempting to call unbound fn: #'metabase.util/snake-key

This is because the function snake-key is replaced with ->snake_case_en in PR

This PR replaces the usage of the old function with the new one.

Checklist

Delete items not relevant to your PR:

Resolves https://github.com/ClickHouse/metabase-clickhouse-driver/issues/161

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

slvrtrn commented 1 year ago

Thanks for the quick fix!

slvrtrn commented 1 year ago

@dodg3this, I checked it locally. This commit does not seem to be a part of the 0.46.3 tag; it's in the master branch. There is no mention of snake_case_en in the source code on my v0.46.3 checkout, but the old snake-key is still there.

Are you sure you were not running the latest master build instead of 0.46.3?

image image

dodg3this commented 1 year ago

Sorry about the false alarm. You're right. I am working with the master branch.

slvrtrn commented 1 year ago

@dodg3this, no worries! Thanks for the commit anyway; it will be useful for 0.47+. I will keep it open until then.