Query log is enabled by default for the test ClickHouse instance
Date bucketing functions refactoring
Better test package structuring
Unit tests where reasonably possible (week tests are omitted; there are many such tests in the main Metabase tests with all possible starting days and all of that).
The issue here was mainly in the ResultSet values extraction. After the introduction of the new value wrappers in the JDBC driver, integer types were cast to strings by default, and Metabase UI did not like that. Surprisingly, most of the other stuff was still working as expected.
The charts look better now (my Metabase instance's week starts on Sunday):
NB: "53rd" week resets to the "1st" again, and it was reported in the main Metabase repo. That is odd behavior; I wasn't able to figure out a fix on the driver level.
Checklist
[x] Unit and integration tests covering the common scenarios were added
[x] A human-readable description of the changes was provided to include in CHANGELOG
Summary
The issue here was mainly in the ResultSet values extraction. After the introduction of the new value wrappers in the JDBC driver, integer types were cast to strings by default, and Metabase UI did not like that. Surprisingly, most of the other stuff was still working as expected.
The charts look better now (my Metabase instance's week starts on Sunday):
NB: "53rd" week resets to the "1st" again, and it was reported in the main Metabase repo. That is odd behavior; I wasn't able to figure out a fix on the driver level.
Checklist