ClickHouse / metabase-clickhouse-driver

ClickHouse database driver for the Metabase business intelligence front-end
Apache License 2.0
461 stars 84 forks source link

Filter Custom Expression fails for week/now combination #185

Closed Tony-metabase closed 11 months ago

Tony-metabase commented 11 months ago

Describe the bug

Steps to reproduce

  1. New -> GUI Question -> Select Table -> Filter on Custom Expression -> week(now
image
  1. Click Enter - It fails
image

Expected behaviour

I am able to click now()

Error log

Only frontend logs:

image

Configuration

Environment

ClickHouse server

slvrtrn commented 11 months ago

is it working with something like week(now) > 30?

Tony-metabase commented 11 months ago

Yes indeed it does but the issue is that it break the whole screen when you start typing week(now and prompt to do an enter?

It doesn't happen on any other DB i am connected with (MYSQL, Snowflake, PGSQL)

slvrtrn commented 11 months ago

Could you test it with MB 0.47-RC2 and driver version 1.2.0? It is working fine there, as everything shows up correctly. It might have been related to #178 (we generally had suboptimal base type inference prior to 1.2.0).

The last suspicious thing is latest - yandex/clickhouse-server. It is deprecated, and you should use https://hub.docker.com/r/clickhouse/clickhouse-server

Tony-metabase commented 11 months ago

The issue seems to be the version. Tried on 0.47-RC2 and version 1.2.0 and wasn't able to replicate