Doesn't pass JDBC version in user agent

ClickHouse / metabase-clickhouse-driver

ClickHouse database driver for the Metabase business intelligence front-end

Apache License 2.0

476 stars 92 forks source link

Doesn't pass JDBC version in user agent #247

Open mshustov opened 3 months ago

mshustov commented 3 months ago

Describe the bug

JDBC version is expected to be set in client name. actual result: metabase/1.3.3/unknown (Linux/6.1.0-12-amd64; OpenJDK 64-Bit Server VM/Temurin-11.0.22+7; HttpURLConnection; rv:unknown)

chernser commented 3 months ago

Would it be a good idea to follow guidelines for the User-Agent header? https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent It means that client will add its version on its own and result would look like metabase/1.3.3 (Linux/6.1.0-12-amd64; OpenJDK 64-Bit Server VM/Temurin-11.0.22+7;) ClickHouseJDBC/0.6.1 (HttpURLConnection; Apache HC 5.2.0)

chernser commented 3 months ago

Just in case here is a Java Client issue https://github.com/ClickHouse/clickhouse-java/issues/1698

slvrtrn commented 3 months ago

I will leave this open as a reminder to upgrade the JDBC driver when the fix is out.