search

ClickHouse / metabase-clickhouse-driver

ClickHouse database driver for the Metabase business intelligence front-end
Apache License 2.0
476 stars 92 forks source link

Fix support for Metabase CI and future-proof DDL statements #273

Open crisptrutski opened 3 days ago

crisptrutski commented 3 days ago

Summary

This PR started as future proofing for an upcoming HoneySQL update which requires explicit quoting of identifiers in some cases.

As part of this work I got the main Metabase upload's test suite running against the driver. This required some updates to the driver to track interface changes, and also revealed some small bugs, which have also been fixed.

NOTE: this version will not be safe for v50 without further changes. Confirmed that this works with the upcoming version of v50.

Checklist

slvrtrn commented 3 days ago

NOTE: this version will not be safe for v50 without further changes.

Shall we wait until 0.51 and merge after that?

crisptrutski commented 2 days ago

Shall we wait until 0.51 and merge after that?

I think after https://github.com/metabase/metabase/pull/48233 merges we'll be good to release after its following point release. Will rerun the suite locally after the backport is merged.

crisptrutski commented 2 days ago

The upload test suite is fully passing with this change on v50 now 😄

(The changes to test/data need to be rolled back to run them though)