ClickHouse / spark-clickhouse-connector

Spark ClickHouse Connector build on DataSourceV2 API
https://clickhouse.com/docs/en/integrations/apache-spark
Apache License 2.0
187 stars 66 forks source link

Core, Test: Refactor tests to support ClickHouse Cloud #349

Closed mzitnik closed 3 months ago

mzitnik commented 3 months ago

Summary

Add Cloud test according to @pan3793 development https://github.com/pan3793/spark-clickhouse-connector/tree/cloud-test

Checklist

Delete items not relevant to your PR:

pan3793 commented 3 months ago

overall lgtm if tests pass, just small nits. thanks for making it work

mzitnik commented 3 months ago

Thanks, @pan3793 yes we have some improvements that we need to make

pan3793 commented 3 months ago

we'd better fix the flaky issues before merging to keep the CI stable ...

sorry, it's midnight in my timezone, I have to go to bed now, will take another look tomorrow

mzitnik commented 3 months ago

When we run it locally, it works perfectly. Maybe somehow related to the Github