ClickHouse / terraform-provider-clickhouse

Terraform Provider for ClickHouse Cloud
Apache License 2.0
23 stars 7 forks source link

Backup configuration not implemented #156

Closed lukipro closed 1 month ago

lukipro commented 1 month ago

We'd like to configure backups for our Clickhouse services in Terraform. Skimming through the source code we noticed that the /backupConfiguration is not implemented. Any plans to have it anytime soon?

Thanks

whites11 commented 1 month ago

Hello @lukipro

Thanks for reaching out.

We currently don't have any plans to cover this feature in our terraform provider, but I will submit your request to the product team and we'll consider it for next planning phase.

cc @krithika-ch

krithika-ch commented 1 month ago

@lukipro : Thanks for the feedback, I am on the product team. We will add this to the next version.

whites11 commented 1 month ago

@lukipro release 1.2.0 of the terraform provider and it allows setting backup configuration.

lukipro commented 1 month ago

Awesome, that was fast :) Thanks 🍻

lukipro commented 1 month ago

Hate to spoil the party, but I think you used wrong validation logic for the backup config: backup_period_in_hours has ["24" "48" "72" "96" "120" "144" "168" "336" "504" "672" "720"] backup_retention_period_in_hours has ["6" "8" "12" "16" "20" "24" "36" "48"]

I guess it should be the other way around.