ClickHouse / terraform-provider-clickhouse

Terraform Provider for ClickHouse Cloud
Apache License 2.0
23 stars 8 forks source link

Development tier backup_configuration #167

Closed robgordon89 closed 1 month ago

robgordon89 commented 1 month ago

Having some weird issues upgrading provider with development tier services , im not sure where the issue lies but im always getting.

Error: Error setting service backup configuration

  with module.dev.module.clickhouse.clickhouse_service.service,
  on dev/clickhouse/main.tf line 1, in resource "clickhouse_service" "service":
   1: resource "clickhouse_service" "service" {

Could not update service backup settings, unexpected error: status: 400,
body:
{"requestId":"90ab9fdd-4446-4d44-a9fe-aeecc29af7de","error":"BAD_REQUEST:
cannot update backup configuration for development tier
service","status":400}

The plan doesn't show any changes to the backup_configuration, i have tried removing state and reimporting to no avail 🤷

prakashbalaji commented 1 month ago

@robgordon89 - I had the same issue recently as Clickhouse development cluster does not support backup configuration. This is constantly being shown in the plans though and apply fails.

Adding ignore_lifecycle to resource clickhouse_service should solve this till the actual fix is made to make backup_configuration optional for development cluster.

lifecycle  {
      ignore_changes = [ backup_configuration ]
    }
whites11 commented 1 month ago

Hey @robgordon89 @prakashbalaji

while I can't replicate the

This is constantly being shown in the plans though and apply fails.

part, there is definitely a mistake in the provider, because as you pointed out setting backup config for development services is not supported.

I merged a fix for this and I'll release it soon. Keep you posted.

robgordon89 commented 1 month ago

Nice thanks for the fix for this, i will wait for a release to test 👍

whites11 commented 1 month ago

release 1.2.2 is out, hopefully fixing this issue. Please accept my apologies for the disruption.

robgordon89 commented 1 month ago

👍 perfect, fixed my issue thanks so much