search

ClickSend / clicksend-nodejs

ClickSend Node.js SDK (Typescript)
12 stars 15 forks source link

Outdated Packages and Weird Installation Method #10

Open nmggithub opened 5 months ago

nmggithub commented 5 months ago

This library uses both bluebird and request, two packages that are extremely outdated and honestly no longer needed. Bluebird was meant to be a polyfill for the Promise API before it was widely supported (which it is now). It's last release was 5 years ago. The request package has been deprecated since 2020 (https://www.npmjs.com/package/request).

The method of installing this package is also very strange. While I do enjoy TypeScript, I have never seen a package on NPM distributed with TypeScript code itself with steps to compile it. The standard appears to be to provide JS files, along with TS types. which is not done here. Requiring a compiling step is an anti-pattern and would honestly break most development processes.

torchsmith commented 2 months ago

It's the wild west over at clicksend

startswithaj commented 3 weeks ago

Whipped up a quick wrapper: https://github.com/startswithaj/clicksend-nodejs-precompiled https://www.npmjs.com/package/click-send-nodejs-precompiled

giorgosph commented 1 week ago

I am deploying my server with AWS CodeDeploy and to resolve the problem I have added a script on the AfterInstall step (where I also build my project's ts), the following lines:

cd /path/to/project/node_modules/clicksend
npx tsc --target es5 api.ts