search

ClickSend / clicksend-php

A wrapper for our REST API - SMS, voice, post, email, fax.
27 stars 14 forks source link

fix: return type issue for php8.1 #27

Closed phpsa closed 6 months ago

phpsa commented 2 years ago

See Issue: https://github.com/ClickSend/clicksend-php/issues/26

adds [\ReturnTypeWillChange] attribute as needed

BafS commented 2 years ago

@mriecken any chance we can merge this? It's waiting since a while

BafS commented 2 years ago

@Jaxom-ClickSend @pauldclicksend @mriecken would it be possible to have a look please? It would be great to maintain the official library

michaelbutler commented 2 years ago

@BafS Unfortunately, most of this repository is autogenerated code so we can't just manually change the code. If you look at the file headers it is autogenerated by swagger. Also unfortunately, swagger needs to update their code to support this too! Someone opened an issue here:

https://github.com/swagger-api/swagger-codegen/issues/11820

I would recommend opening a PR there, once swagger is updated to support it, ClickSend can re-run the latest swagger to auto-generate with full PHP 8 support.

mriecken commented 2 years ago

@michaelbutler is right - this is auto-generated code. We use Swagger / OpenAPI to generate the code you see here.

We've been discussing a long-term solution with the dev team and this is the approach we are going for:

Because our tooling doesn't allow us to template out the generated code, we are building a tool that does a post-code generation modification of the source. We will need to modify our test platform to test for these changes, of course. Once we have to tooling fixed and the test coverage working, we can release this.

I understand that this has been slow going and I am grateful for your patience.

If possible, we will release our code modification hack to you prior to the test automation being complete so that you can apply it yourself - obviously with the caveat that this voids warrantees.

Once we ensure that the changes pass all tests (they should - this isn't a deep change), we will merge the PR and make this GA.

Our much longer solution is to change the tool that we use for code generation. We won't be able to re-tool for our V3 product (which you use currently), but are in-building a solution for our V4 product.

Thank you for your patience and kindness. All the best

Michael

BafS commented 2 years ago

Thank you for your message @mriecken. I did a PR there https://github.com/swagger-api/swagger-codegen/pull/11846 to fix it in swagger-codegen but there is no activity so far.

sudo-plz commented 1 year ago

swagger-codegen is updated, any possibility we can see a new clicksend-php release :pleading_face:?

BafS commented 1 year ago

@mriecken could we update the repo with the last generated files?

BafS commented 1 year ago

Any news? This PR is open since almost a year now and the fix was merged upstream

BafS commented 1 year ago

@mriecken any new? This issue is pending since a year now I did the change in the swagger repo thinking you guys could regenerate the files soon.

davidcumberland commented 1 year ago

How's this branch going? Just signed up and started testing, got spammed with deprecation notices.

BafS commented 1 year ago

The repo is pretty much unmaintained, there is no answer from the company since months. We are using this fork: https://github.com/phpsa/clicksend-php and we plan to use https://github.com/symfony/symfony/tree/6.4/src/Symfony/Component/Notifier/Bridge/ClickSend

michaelbutler commented 1 year ago

Thanks @BafS . Or you could just use the REST API directly using your own simple class using CURL.

BafS commented 6 months ago

Looks like it's finally fixed with this commit: https://github.com/ClickSend/clicksend-php/commit/dfd555424da4c7d5cfc4dd8b812957c7ee6becc4

phpsa commented 6 months ago

Closing this now as tagged v5 available @5.0.79