search

ClickerMonkey / SemanticUI-Angular

Angular Directives for Semantic UI
http://clickermonkey.github.io/SemanticUI-Angular/examples/
MIT License
56 stars 28 forks source link

Fix drop down box programmatic update #14

Closed evenflow58 closed 7 years ago

evenflow58 commented 7 years ago

The watch function was ignoring any changes after the initial set because of the ignoreUpdate variable. I left the ignoreUpdate variable in because I couldn't figure out the purpose. I also haven't noticed any issues but I do not use the full suite.

evenflow58 commented 7 years ago

Fixes #13

ClickerMonkey commented 7 years ago

Thanks, I'll test it out and merge in your changes this week. IgnoreUpdate is a variable used to keep an angular digest cycle from occurring after you apply a value and update the UI - which subsequently would try to apply the same value. This was all done before I had the best grasp on angular so it's in need of a good refactoring anyway.

ClickerMonkey commented 7 years ago

Closing this for now, several issues surrounding the dropdown will be fixed when the library stops using model and starts using the ngModel directive & controller.