Fix for stripped html on dropdown clear

ClickerMonkey / SemanticUI-Angular

Angular Directives for Semantic UI

http://clickermonkey.github.io/SemanticUI-Angular/examples/

MIT License

56 stars 28 forks source link

Fix for stripped html on dropdown clear #32

Closed aphotix closed 6 years ago

aphotix commented 6 years ago

Added a second conditional for dropdown used as navigation. Clear seems to strip the html out of the default text, reset does not. setting the dropdown model to false will now reset the dropdown programmatically when used as a menu without eliminating the option to clear the menu. Patch for #31

ClickerMonkey commented 6 years ago

Is this patch ready - and do you feel like it was adequately tested?

aphotix commented 6 years ago

All of the examples work identically with this update compared to the prior update; pull request #28.

The changes made to sm-core.js on pull request #28 did introduce a defect when using the setting 'useLabels: false' and angular 1.3.14. If you select an option it immediately clears the value. This does not occur if you use Angular 1.6.4 instead of 1.3.14, which may explain how it could have been missed.