search

Clicksco / Front-End

Organisation Front End Documentation & Tooling
http://docs.clicksco.com/frontend
2 stars 1 forks source link

Added a base HTML file and removed banner options from Gruntfile #53

Closed BenjaminRCooper closed 10 years ago

lewismorris commented 11 years ago

Hey Ben,

This looks good, only changes i would possibly make are the following;

Change .page-wrapper to .wrapper just makes it more re-usable in my opinion, but i'm open to discussion on this.

Also on the boilerplate removing

<!--[if lt IE 7 ]> <html class="ie6"> <![endif]-->
<!--[if IE 7 ]>    <html class="ie7"> <![endif]-->

I'm more than certain we won't be testing under IE8 and in the rare case in which we do we these can be manually added into the template.

BenjaminRCooper commented 11 years ago

Good call.

B

timgale commented 11 years ago

Looking good.

Is it worth adding the lang attribute to the html tag? Could be useful if we work towards multilingual sites in the future.

Tim

BenjaminRCooper commented 11 years ago

Another good call

lewismorris commented 11 years ago

Good shout Tim.

How about we drop in a meta tag to force IE to render in it's latest engine or chrome frame if installed?

<meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1">

Haven't really found any pitfalls with using it over the past 12 months or so.

BenjaminRCooper commented 11 years ago

Yeah, was going to add it, just never had any experience so couldnt see the benefits.

Will do that too

B

BenjaminRCooper commented 11 years ago

I haven't implemented the chrome frame attribute value, as I feel it is a very small majority of people who have this installed, and it being deprecated as of January 2014

Ben

lewismorris commented 11 years ago

No worries, i haven't checked Chrome frame since the beginning of the year so didn't know it was on it's way out. This looks good to me though, if everyone else is happy i'll merge this in?

jonspark commented 11 years ago

@lewismorris @Passenger-Inspired This should be put into a .htaccess file, it breaks HTML validation.

<meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1">

This should cover it:

<FilesMatch "\.(htm|html|php)$">
    <IfModule mod_headers.c>
        BrowserMatch MSIE ie
        Header set X-UA-Compatible "IE=Edge,chrome=1" env=ie
    </IfModule>
</FilesMatch>
BenjaminRCooper commented 11 years ago

Good shout mate :)

Should really look into adding some rules to a base .htaccess file, which I think will come from our performance standards.

Hope the family are good mate :)

Get off GH, going look after little benji james park ;)

Ben

iamrossgrant commented 11 years ago

Good shout on the .htaccess John, I didn't realise it didn't validate, just goes to show the last time I checked a site for validation :)

Would it be worth including -

BenjaminRCooper commented 11 years ago

Question on this, adding this to the htaccess file is not going to make to much of a difference, as this will not be picked up by an Nginx server anyway right?

With regards to the validation issue, I don't see it being too much of an issue, validation is not as important as it used to be and it does not stop the page from rendering anyway.

B

lewismorris commented 11 years ago

I believe your correct @Passenger-Inspired this wont work on a Nginx server, there may be a convertor online that'll provide the correct version?

+1 on the validation, i don't think it's massively important. As long as your markup as a whole validates the odd meta tag should not really make any difference imo.

BenjaminRCooper commented 11 years ago

Added a sections partial directory to contain global site element styles such as; header, footer and sidebar styles.

Thoughts?

B

lewismorris commented 11 years ago

If everyone is happy with this, i'll merge it in? +1 from me.

jonspark commented 10 years ago

Putting add_header "X-UA-Compatible" "IE=Edge,chrome=1"; in the nginx server block will work just the same.

That's a one for the sysadmin, however.

BenjaminRCooper commented 10 years ago

Let's keep it within the HTML directly, as we know how hard it is to get something done that end.

Also, having it within the HTML will mean it is not forgotten, where as if we did it this way, it would need to be added for every project.

Ben