ClickteamLLC / windows-edif

Alternate, JSON-driven SDK for the Windows MMF2 runtime
23 stars 7 forks source link

Automatically detect rCom, rMvt, rSpr, and rVal #11

Closed LB-- closed 11 years ago

LB-- commented 11 years ago

This change makes it so that the OEFLAGs defined in Extension.h will automatically change the RUNDATA structure accordingly so that users do not have to uncomment lines themselves. The RUNDATA structure has been moved from Common.h to the end of Edif.h because it no longer needs to change per-extension. The changes can accommodate any combination of OEFLAG_MOVEMENTS, OEFLAG_SPRITES, and OEFLAG_VALUES.

jamesamcl commented 11 years ago

This is a really nice idea. My only concern is that it'll change the size of RUNDATA for existing extensions - I wonder if there's a way we can automate the UpdateEditStructure thing for this change?

LB-- commented 11 years ago

Extensions upgrading from past EDIF versions just need to remove their RUNDATA structure from Common.h. UpdateEditStructure is for EDIDATA, the RUNDATA structure can be freely resized across extension versions because it is dealt with at runtime.

jamesamcl commented 11 years ago

Ah! Sorry, for some reason I was reading RUNDATA and thinking EDITDATA. Looking good, then.