search

ClickteamLLC / windows-edif

Alternate, JSON-driven SDK for the Windows MMF2 runtime
23 stars 7 forks source link

Corruption with Sub Applications #15

Closed LB-- closed 9 years ago

LB-- commented 11 years ago

Multiple users have been reporting extension corruption at runtime when sub-applications are present in the frame, even if they have nothing to do with the extension. I have had PMs from user prester, and ProdigyX has started this thread about it.

Prester informs me that both this official version of EDIF and my version of EDIF are affected.

@Andos @udp I have no idea what could be causing this, I am not familiar with how the internals of MMF2 work or why a sub application could affect extensions like this.

steve-taylor commented 9 years ago

My extension crashes its host runtime when instantiated inside a frame that belongs to a sub-application. This happens even when the object isn't used in any way.

My extension: https://github.com/steve-taylor/mmf2-blowfish-cipher

MMF2 build 251 (can't upgrade yet).

ClickT commented 9 years ago

I didn't check your source code but it seems a fix hadn't been propagated to this version. An unitialized icon at runtime could cause a crash. This fix has just been pushed, try it.

steve-taylor commented 9 years ago

Thanks @ClickT. I updated to the latest commit, but sadly it still crashes when the sub-application whose contained frame contains my extension is instantiated.

steve-taylor commented 9 years ago

I switched to @LB--'s EDIF and merged this change into that and I no longer get the crash. I don't know if the crash resolved just by his EDIF or by the combination of his EDIF and this fix.

LB-- commented 9 years ago

I merged https://github.com/ClickteamLLC/windows-edif/commit/ab434ed64dcac30f76533cffd0b9143469173776 into https://github.com/LB--/windows-edif/commit/85338913b88f648dc7fdc2793853d63ebb19cddf so hopefully it should be fixed for anyone using my fork in the future. I'll ask ProdigyX to run his test case again and if it is fixed for him I'll close the issue.

EDIT: I'm also asking prester again.

LB-- commented 9 years ago

Prester and ProdigyX both report that https://github.com/LB--/windows-edif/commit/85338913b88f648dc7fdc2793853d63ebb19cddf fixes their issue. Prester says that with https://github.com/ClickteamLLC/windows-edif/commit/ab434ed64dcac30f76533cffd0b9143469173776 the issue still happens, so probably the fix is in #18 - I'll close this issue and merge https://github.com/ClickteamLLC/windows-edif/commit/ab434ed64dcac30f76533cffd0b9143469173776 into #18